Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-3279: PAS Fix Limitation Documentation #18

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

degradification
Copy link
Contributor

@degradification degradification commented Oct 24, 2024

Description

This ticket updated the validation genetor in order to add the limitation to all validation tests without the need to do so manually. Also fixed the limitation text updating from DTR to PAS

Important Changes

lib/davinci_pas_test_kit/generator/validation_test_generator.rb

  • Added limitation documentation to the generator

Added updated validation tests with limitation documentation for the following files

  • lib/davinci_pas_test_kit/generated/v2.0.1/client_tests/client_denial_pas_response_bundle_validation_test.rb
  • lib/davinci_pas_test_kit/generated/v2.0.1/client_tests/client_pas_request_bundle_validation_test.rb
  • lib/davinci_pas_test_kit/generated/v2.0.1/client_tests/client_pended_pas_inquiry_request_bundle_validation_test.rb
  • lib/davinci_pas_test_kit/generated/v2.0.1/client_tests/client_pended_pas_response_bundle_validation_test.rb
  • lib/davinci_pas_test_kit/generated/v2.0.1/pas_inquiry_request_bundle/server_pas_inquiry_request_bundle_validation_test.rb
  • lib/davinci_pas_test_kit/generated/v2.0.1/pas_inquiry_response_bundle/server_pas_inquiry_response_bundle_validation_test.rb
  • lib/davinci_pas_test_kit/generated/v2.0.1/pas_request_bundle/server_pas_request_bundle_validation_test.rb
  • lib/davinci_pas_test_kit/generated/v2.0.1/pas_response_bundle/server_pas_response_bundle_validation_test.rb

Fixed typos for the following files

  • README.md
  • lib/davinci_pas_test_kit/docs/client_suite_description_v201.md
  • lib/davinci_pas_test_kit/docs/server_suite_description_v201.md

Testing Recommendations

Make sure all unit tests pass and the application runs as expected. Run both the Client and Server suite and ensure that the limitation statement "Due to recognized errors in the PAS IG around extension context definitions, this test may not pass due to spurious errors of the form "The extension [extension url] is not allowed at this point". See [this issue] for additional details." appears for the following tests in their about sections.

PAS Client

  • 2.1.1 Demonstrate Approval Workflow

    • 2.1.1.02 Request Bundle is valid
  • 2.1.2 Demonstrate Denial Workflow

    • 2.1.2.02 [USER INPUT VALIDATION] Response Bundle is valid
    • 2.1.2.03 Request Bundle is valid
  • 2.1.3 Demonstrate Pended Workflow

    • 2.1.3.02 [USER INPUT VALIDATION] Response Bundle is valid
    • 2.1.3.03 Request Bundle is valid
    • 2.1.3.06 Inquiry Request Bundle is valid

PAS Server

  • 1.1 Successful Approval Workflow

    • 1.1.1.01 [USER INPUT VALIDATION] Request Bundle is valid
    • 1.1.1.03 Response Bundle is valid
  • 1.2 Successful Denial Workflow

    • 1.2.1.01 [USER INPUT VALIDATION] Request Bundle is valid
    • 1.2.1.03 Response Bundle is valid
  • 1.3 Successful Pended Workflow

    • 1.3.1.01 [USER INPUT VALIDATION] Request Bundle is valid
    • 1.3.1.03 Response Bundle is valid
    • 1.3.2.02 [USER INPUT VALIDATION] Inquiry Request Bundle is valid
    • 1.3.2.04 Inquiry Response Bundle is valid
  • 2.2 $inquire Element Support

    • 2.2.1.01 [USER INPUT VALIDATION] Inquiry Request Bundle is valid
    • 2.2.1.03 Inquiry Response Bundle is valid

Additionally ensure generator runs as expected bundle exec rake pas:generate

Checklists

Submitter:

  • This MR describes why these changes were made.
  • This MR is into the correct branch (usually 'main').
  • Comment added to the relevant Jira ticket(s) with a link to this MR.
  • The relevant Jira ticket has been moved to 'Peer Review' (may be N/A if a Jira ticket is associated with multiple MRs)
  • Code diff has been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.).
  • Ensure automated tests pass successfully.

Final Merger

  • The necessary number of reviews/approvals have been received on this PR and all checklists have been completed.
  • The relevant Jira ticket has been moved to 'Done' (may N/A if a Jira ticket is associated with multiple MRs)

-Fixed typos in README & docs
-Added limitation statement to validation tests through the generator
-Fixed limitation text DTR -> PAS
@degradification degradification self-assigned this Oct 24, 2024
@degradification degradification added the documentation Improvements or additions to documentation label Oct 24, 2024
@degradification degradification marked this pull request as ready for review October 24, 2024 12:07
@degradification degradification merged commit 19f96d1 into main Oct 24, 2024
3 checks passed
@degradification degradification deleted the fi-3279-pas-fix-limitation-documentation branch October 24, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants