FI-2185 and FI-2186: Add Optional Tests for _lastUpdated Interaction and Required Tests for _id Search #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emichaud998
force-pushed
the
FI-2185-SHOULD_optional_tests
branch
2 times, most recently
from
6555707 to
2dd956c
Compare
…h test so that it does not fail if no _lastUpdated param added or if search for _lastUpdated fails for Coverage resource
…hat are not SHALL requirements. Updated optional? method so that it checks if search_metadata is nil before checking if it is empty
…dy marked as optional
… test is optional
…nal if optional is included
…, and related_person
… for _lastUpdated tests that already exist, add spec tests for all of the new optional _lastUpdated tests
…tient, Practitioner, Organization, and Related Person resource. Creates the id and lastUpdated test for all of these resources and makes lastUpdated optional
emichaud998
force-pushed
the
FI-2185-SHOULD_optional_tests
branch
from
2051176 to
b0ddfd0
Compare
emichaud998
changed the title
…g, move _lastUpdated tests to search test spec file, add in test for _id search
emichaud998
changed the title
vanessuniq
requested changes
Nov 1, 2023
...tton_test_kit/generated/v2.0.0-dev-nonfinancial/coverage/coverage_lastupdated_search_test.rb
Show resolved
Hide resolved
...t_kit/generated/v2.0.0-dev-nonfinancial/organization/organization_lastupdated_search_test.rb
Show resolved
Hide resolved
...button_test_kit/generated/v2.0.0-dev-nonfinancial/patient/patient_lastupdated_search_test.rb
Show resolved
Hide resolved
...t_kit/generated/v2.0.0-dev-nonfinancial/practitioner/practitioner_lastupdated_search_test.rb
Show resolved
Hide resolved
...t/generated/v2.0.0-dev-nonfinancial/related_person/related_person_lastupdated_search_test.rb
Show resolved
Hide resolved
…rces when no _lastUpdated param is passed in. Updated spec test to reflect these changes
… search tests now skip if the search parameter is blank. Updated spec tests accordingly and ran generator with these changes
yunwwang
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changed _lastUpdated test for Coverage resource to be an optional test, and added optional tests for all the additional _lastUpdated interactions for the Patient, Organization, Practitioner, and RelatedPerson resources. Added _id search test for Patient, Organization, Practitioner, and RelatedPerson resources as well. Also added spec tests for _lastUpdated and _id search tests.
Testing Guidance
Can run the spec tests by running
bundle exec rspec spec/carin_for_blue_button/carin_search_test_spec.rband make sure all the tests pass. Otherwise, you can run Inferno locally and test the _lastUpdated and _id tests manually by running those tests for the Coverage, Patient, Organization, Practitioner, and RelatedPerson resources using a local instance of the C4BB RI.