Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-2186 Coverage Optional _lastUpdated #19

Closed
wants to merge 8 commits into from

Conversation

emichaud998
Copy link
Contributor

Summary

Fixed Coverage test so that the _lastUpdated param is optional, and so that if _lastUpdated is passed in but is unsuccessful, a warning is displayed and the test is skipped instead of failing.

Testing Guidance

You can run the rspec _lastUpdated tests that make sure Coverage _lastUpdated tests are optional but EOB _lastUpdated tests are required by running bundle exec rspec spec/carin_for_blue_button/carin_search_test_last_updated.rb, or you can run Inferno locally and ensure _lastUpdated test for Coverage resource is optional and works as expected.

…h test so that it does not fail if no _lastUpdated param added or if search for _lastUpdated fails for Coverage resource
Copy link
Contributor

@vanessuniq vanessuniq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the _lastUpdated test itself is optional, we should just mark the test as optional (adding the optional attribute to that class).

@vanessuniq
Copy link
Contributor

vanessuniq commented Oct 30, 2023

Since the _lastUpdated test itself is optional, we should just mark the test as optional (adding the optional attribute to that class).

Actually, I think the change should be at the generator level as opposed to make edits to individual tests. The search_test_generator.rb has a method optional? that checks if the a given search param conformance expectation is required or not. So I think we can just modify the template (lib/carin_for_blue_button_test_kit/generator/templates/search.rb.erb) to add the optional attribute to the test if optional? method returns true. Adding the following in that template file under id :<%= test_id %> at line 14:

<% if optional? %>
      optional
<% end %>

Then rerun the generator bundle exec rake carin4bb:generate.
This will properly handle required and optional search tests for all IG versions. @yunwwang can confirm if it makes sense.

@emichaud998 emichaud998 closed this Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants