-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FI-2186 Coverage Optional _lastUpdated #19
Conversation
…h test so that it does not fail if no _lastUpdated param added or if search for _lastUpdated fails for Coverage resource
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the _lastUpdated test itself is optional, we should just mark the test as optional
(adding the optional attribute to that class).
Actually, I think the change should be at the generator level as opposed to make edits to individual tests. The <% if optional? %>
optional
<% end %> Then rerun the generator |
…initions section so that they are no longer blank
…hat are not SHALL requirements. Updated optional? method so that it checks if search_metadata is nil before checking if it is empty
…dy marked as optional
… test is optional
…nal if optional is included
Summary
Fixed Coverage test so that the _lastUpdated param is optional, and so that if _lastUpdated is passed in but is unsuccessful, a warning is displayed and the test is skipped instead of failing.
Testing Guidance
You can run the rspec _lastUpdated tests that make sure Coverage _lastUpdated tests are optional but EOB _lastUpdated tests are required by running
bundle exec rspec spec/carin_for_blue_button/carin_search_test_last_updated.rb
, or you can run Inferno locally and ensure _lastUpdated test for Coverage resource is optional and works as expected.