-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cmake] Remove conan package manager and use only CMake instead #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IAmNotHanni
added
the
cat:dev tools
building/ compiling the program, cmake configuration and general development tools
label
Apr 11, 2023
IAmNotHanni
requested review from
westernheld,
aschaeffer,
movabo,
yeetari,
a-teammate and
IceflowRE
April 11, 2023 17:01
IAmNotHanni
force-pushed
the
yeetari/no-conan
branch
from
April 11, 2023 17:18
266ef63
to
a723652
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
IAmNotHanni
force-pushed
the
yeetari/no-conan
branch
from
April 11, 2023 19:02
fc4f981
to
0debca6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
IAmNotHanni
force-pushed
the
yeetari/no-conan
branch
from
April 11, 2023 19:18
89fccf2
to
6b22266
Compare
This comment was marked as outdated.
This comment was marked as outdated.
IAmNotHanni
force-pushed
the
yeetari/no-conan
branch
2 times, most recently
from
April 11, 2023 20:43
b9b297d
to
45158e8
Compare
On Windows, VMA must be configured with EDIT: This is only the case if your (my) outdated graphics card does not support Vulkan 1.3 hahah. I guess it's also time for my new machine to arrive :) Read more here: GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator#280 Oh man it's really about time we use volk metaloader! |
IAmNotHanni
force-pushed
the
yeetari/no-conan
branch
5 times, most recently
from
April 12, 2023 23:14
d10c009
to
cd73c2c
Compare
IAmNotHanni
changed the title
Remove conan and use only CMake instead
[cmake] Remove conan package manager and use only CMake instead
Apr 12, 2023
IAmNotHanni
added
the
prio:blocker
this issue cannot be moved to a later milestone, also this label cannot be removed
label
Apr 12, 2023
IceflowRE
requested changes
Apr 13, 2023
IceflowRE
requested changes
Apr 13, 2023
IAmNotHanni
force-pushed
the
yeetari/no-conan
branch
5 times, most recently
from
May 8, 2023 23:51
fa76daf
to
269cd4c
Compare
|
IAmNotHanni
force-pushed
the
yeetari/no-conan
branch
10 times, most recently
from
May 11, 2023 08:54
e13a263
to
ada50ed
Compare
IceflowRE
reviewed
May 11, 2023
IceflowRE
approved these changes
May 11, 2023
Co-authored-by: Iceflower <[email protected]> Co-authored-by: Owen Smith <[email protected]>
Co-authored-by: Iceflower <[email protected]> Co-authored-by: Owen Smith <[email protected]>
Co-authored-by: Iceflower <[email protected]> Co-authored-by: Owen Smith <[email protected]>
Co-authored-by: Iceflower <[email protected]> Co-authored-by: Owen Smith <[email protected]>
Co-authored-by: Iceflower <[email protected]> Co-authored-by: Owen Smith <[email protected]>
Co-authored-by: Iceflower <[email protected]> Co-authored-by: Owen Smith <[email protected]>
IAmNotHanni
force-pushed
the
yeetari/no-conan
branch
from
May 11, 2023 16:18
ada50ed
to
b5ffd65
Compare
yeetari
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cat:dev tools
building/ compiling the program, cmake configuration and general development tools
prio:blocker
this issue cannot be moved to a later milestone, also this label cannot be removed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please test this!
Closes #522
Closes #512
Closes #501
History
Conan package manager is no longer required, as all dependencies can be downloaded simply through CMake by now. While in my personal opinion CMake has improved a lot over time, conan has not. It has been a constant source of frustration and broken build setups, most importantly our broken CI. Furthermore, I get the impression that almost nobody who comes into our project has any experience with conan, while most people have heard or use CMake. Using CMake+conan is just some thing in our project that has grown over time, but I think it's justified to say goodbye to it.
Note: Because we will no longer use conan to install Vulkan tools, this pull request will reverse #491
INEXOR_USE_VMA_RECORDING
option (deprecated in VMA 3.0.0)MeshBuffer
templatemain
iceflower/conan_cmake
actions/upload-artifact@v3
Outlook