Fixing random integer values solution in NumPy exercises #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wonderful tutorials but I've noticed this problem. When prompted:
###Create a numpy array, filled with 3 random integer values between 1 and 10.
The listed solution is
np.random.randint(10, size=3)
But this code will produce a numpy array of size 3 with integer values between 0 and 10, not 1 and 10.
The returned array differs each time, of course, but the first time running the solution code in my notebook returned array([0, 4, 0]).
Instead, the solution code should be
np.random.randint(1, 10, size=3)
to specify 1 as the low value (inclusive) and 10 as the high value (exclusive). I'm ignoring the ambiguity of "between" in the prompt here, but perhaps clarifying inclusive/exclusive would be helpful too.