Remove TensorProductElementGroupBase.bases_1d
#409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
inducer
force-pushed
the
remove-bases-1d
branch
from
ae2a80c
to
7d102e1
Compare
|
This is necessary to get the 1D basis (bases) used to build the TP basis so that we can retrieve 1D operators. inducer/grudge#313 depends on bases_1d for fast operator evaluation to work (sorry if formatting is bad, I'm replying on GH mobile) EDIT: From what I can tell by the changes, this can be worked around in inducer/grudge#313. Seems fine to merge. |
|
OK, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get the tests in inducer/grudge#338 to go, zero-dimensional tensor product discretizations need to work. This
bases_1dthing (which seems kind of ill-defined anyway) was an obstacle. It appeared entirely unused across meshmode and grudge.@a-alveyblanc Do you have any objections to this?