Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firedrake CI should include parallel tests #891

Closed
connorjward opened this issue Nov 29, 2024 · 2 comments · Fixed by #894
Closed

Firedrake CI should include parallel tests #891

connorjward opened this issue Nov 29, 2024 · 2 comments · Fixed by #894

Comments

@connorjward
Copy link
Contributor

By not having parallel tests loopy missed an issue regarding mismatching hashes between ranks. I think if you had parallel tests then this would not have happened.

I think this could be fixed simply be modifying the line

pytest --tb=native -rsxw --durations=10 -m 'not parallel' tests/multigrid/

by removing the -m "not parallel" bit.

Note that we also usually have a different set of "smoke tests" instead of tests/multigrid: https://www.firedrakeproject.org/download.html#testing-the-installation

Further, tests/multigrid has just been moved to tests/firedrake/multigrid.

@inducer
Copy link
Owner

inducer commented Nov 29, 2024

Makes sense, at least as long as the CI time can be kept under control. Could you submit a PR?

@connorjward
Copy link
Contributor Author

Sure. Will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants