Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run parallel Firedrake tests in CI #894

Merged

Conversation

connorjward
Copy link
Contributor

@connorjward connorjward commented Dec 3, 2024

Closes #891

In this change we switch to running the "smoke tests" that Firedrake encourages users to do: https://www.firedrakeproject.org/firedrake/download.html#testing-the-installation

Note that tests are currently failing because of the reason discussed here. This PR can probably follow any other fixes to loopy/Firedrake.

@inducer
Copy link
Owner

inducer commented Dec 3, 2024

Thanks! Are the failures expected? Should anything happen on Loopy's end to fix them?

@connorjward
Copy link
Contributor Author

Thanks! Are the failures expected? Should anything happen on Loopy's end to fix them?

Yes the failures are due to the parallel mismatching hash bug that I mentioned before. I think the best way forward is:

  1. You to merge Revert "Hack dataclass'd function_interface to avoid breaking Firedrake" #886
  2. Myself to fix Firedrake to work with a fully up-to-date loopy. This is 99% of the way there.
  3. Once Firedrake has updated containers this PR may then be merged.

@connorjward
Copy link
Contributor Author

With the latest Firedrake container this is now passing the Firedrake tests. Since this is a single line change I don't expect the other test failures are anything to do with this PR.

@inducer
Copy link
Owner

inducer commented Dec 5, 2024

Thanks for working on this! I agree that the other failures are unrelated. I'll handle them separately.

@inducer inducer merged commit f2ed9db into inducer:main Dec 5, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firedrake CI should include parallel tests
2 participants