add device<->host transfer mappers #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasdiener
commented
Sep 25, 2024
arraycontext/impl/pytato/utils.py
Outdated
| import arraycontext.impl.pyopencl.taggable_cl_array as tga | ||
| if isinstance(expr.data, tga.TaggableCLArray): | ||
| data = expr.data.get() | ||
| return DataWrapper( |
There was a problem hiding this comment.
@majosm asked in inducer/pytato#548 (comment)
Can we make this return an instance of a new
DataWrappertype that can__hash__by data instead ofid? That would remove the need for data wrapper deduplication, if I understand the intended use of these mappers correctly.
There was a problem hiding this comment.
Not sure; in that case, we probably should probably also override the EqualityComparer, otherwise we would get a lot of hash collisions when caching.
3 tasks
|
This is ready for a first review; I'm not sure what to do about the pylint errors. |
matthiasdiener
commented
Sep 26, 2024
|
Please do add these to the docs, and then this should be ready to go. |
Added in b20d359 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup of inducer/pytato#548
Implements part of inducer/pytato#547
TODOs:
Please squash