Write flags into file instead of passing tons of them

indoorvivants · Jul 13, 2024 · ace9af5 · ace9af5
1 parent 0dff473
commit ace9af5
Showing 1 changed file with 52 additions and 10 deletions.
diff --git a/modules/cli/src/main/scala/CommandLineApp.scala b/modules/cli/src/main/scala/CommandLineApp.scala
@@ -11,6 +11,9 @@ import java.io.File
 import java.nio.file.Paths
 import scala.util.Using
 import java.io.FileWriter
+import java.nio.file.Files
+import cats.syntax.writer
+import util.chaining.*
 
 enum Compiler:
   case Clang, ClangPP
@@ -515,26 +518,65 @@ object VcpkgCLI extends VcpkgPluginImpl, VcpkgPluginNativeImpl:
             scalaCliArgs.addOne(scalaCliBin)
             scalaCliArgs.addAll(rest)
 
-            computeNativeFlags(
+            val flags = computeNativeFlags(
               OutputOptions(compile = true, linking = true),
               allDeps,
               result.filter((k, v) => allDeps.contains(k)),
               rename
-            ).foreach {
-              case NativeFlag.Compilation(value) =>
-                scalaCliArgs.addOne("--native-compile")
-                scalaCliArgs.addOne(value)
+            )
+
+            val (linkingFlags, compileFlags) =
+              val (l, c) = flags.partition:
+                case NativeFlag.Compilation(value) => false
+                case NativeFlag.Linking(value)     => true
+
+              (l.map(_.get), c.map(_.get))
+
+            val linkFlagsFile = Files
+              .createTempFile("linking", ".txt")
+              .toFile()
+              .tap(_.deleteOnExit())
+
+            val linkFlagsFileWriter =
+              new FileWriter(
+                linkFlagsFile
+              )
+
+            val compileFlagsFile = Files
+              .createTempFile("compile", ".txt")
+              .toFile()
+              .tap(_.deleteOnExit())
 
-              case NativeFlag.Linking(value) =>
-                scalaCliArgs.addOne("--native-linking")
-                scalaCliArgs.addOne(value)
-            }
+            val compileFlagsFileWriter =
+              new FileWriter(
+                compileFlagsFile
+              )
+
+            Using(linkFlagsFileWriter): linkFlagsFileWriter =>
+              linkingFlags.foreach(f => linkFlagsFileWriter.write(f + "\n"))
+
+            Using(compileFlagsFileWriter): compileFlagsWriter =>
+              compileFlags.foreach(f => compileFlagsWriter.write(f + "\n"))
+
+            scalaCliArgs.addAll(
+              Seq(
+                "--native-linking",
+                s"@${linkFlagsFile.toPath().toAbsolutePath().toString}"
+              )
+            )
+            scalaCliArgs.addAll(
+              Seq(
+                "--native-compile",
+                s"@${compileFlagsFile.toPath().toAbsolutePath().toString}"
+              )
+            )
 
             scribe.debug(
               s"Invoking Scala CLI with arguments: [${scalaCliArgs.result().mkString(" ")}]"
             )
 
-            val exitCode = scala.sys.process.Process(scalaCliArgs.result()).!
+            val exitCode =
+              scala.sys.process.Process(scalaCliArgs.result()).!
 
             sys.exit(exitCode)