Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for code_block filter #157

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

atm-snag2
Copy link
Contributor

What

  • add test for code_block filter

@atm-snag2 atm-snag2 force-pushed the add-test-for-code-block branch 4 times, most recently from 1dbf3ef to 7a41867 Compare April 5, 2024 11:41
@atm-snag2 atm-snag2 assigned atm-snag2 and unassigned atm-snag2 Apr 5, 2024
@inukai-masanori inukai-masanori self-requested a review April 9, 2024 03:18
@atm-snag2 atm-snag2 self-assigned this Apr 9, 2024
inukai-masanori
inukai-masanori previously approved these changes Apr 9, 2024
Copy link
Member

@inukai-masanori inukai-masanori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few comments, but they are minor and I approve them.

HTML
end

it "adds lang on pre " do
Copy link
Member

@inukai-masanori inukai-masanori Apr 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nits] There is a blank space at the end of the sentence. Also, there are more than just this section.

Suggested change
it "adds lang on pre " do
it "adds lang on pre" do

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reviewing
I fixed it.

@atm-snag2 atm-snag2 force-pushed the add-test-for-code-block branch from 8fe7c0d to 8ac0708 Compare April 9, 2024 03:53
Copy link

codeclimate bot commented Apr 9, 2024

Code Climate has analyzed commit 8ac0708 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 99.0% (0.0% change).

View more on Code Climate.

Copy link
Member

@inukai-masanori inukai-masanori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@atm-snag2 atm-snag2 merged commit 02aa5b4 into master Apr 9, 2024
6 checks passed
@atm-snag2 atm-snag2 deleted the add-test-for-code-block branch April 9, 2024 05:35
@Umekawa Umekawa mentioned this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants