Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @typescript-eslint/eslint-plugin from 6.21.0 to 7.0.0 #130

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 8, 2024

Bumps @typescript-eslint/eslint-plugin from 6.21.0 to 7.0.0.

Release notes

Sourced from @​typescript-eslint/eslint-plugin's releases.

v7.0.0

7.0.0 (2024-02-12)

Read more about this release: https://typescript-eslint.io/blog/announcing-typescript-eslint-v7/

🚀 Features

  • add support for flat configs (#7935)

🩹 Fixes

  • eslint-plugin: [prefer-find] stop throwing type errors when converting symbols to numbers (#8390)

⚠️ Breaking Changes

  • ⚠️ bump ESLint, NodeJS, and TS minimum version requirements (#8377)

❤️ Thank You

You can read about our versioning strategy and releases on our website.

Changelog

Sourced from @​typescript-eslint/eslint-plugin's changelog.

7.0.0 (2024-02-12)

🚀 Features

  • ⚠️ bump ESLint, NodeJS, and TS minimum version requirements

  • add support for flat configs

🩹 Fixes

  • eslint-plugin: [prefer-find] stop throwing type errors when converting symbols to numbers

⚠️ Breaking Changes

  • ⚠️ bump ESLint, NodeJS, and TS minimum version requirements

❤️ Thank You

  • Brad Zacher
  • Kirk Waiblinger
  • StyleShit
  • YeonJuan

You can read about our versioning strategy and releases on our website.

Commits
  • b27de99 chore(release): publish 7.0.0
  • 379f742 chore(eslint-plugin): [no-confusing-void-expression] explicitly state default...
  • b636baa docs: fix restrict-plus-operands example (#8362)
  • 1aa393c chore(deps): update dependency prettier to v3.2.5 (#8401)
  • 8ef5f4b feat: add support for flat configs (#7935)
  • c298350 fix(eslint-plugin): [prefer-find] stop throwing type errors when converting s...
  • 1200b4c chore(deps): update nx to v17.3.0 (#8317)
  • 584db29 feat: bump ESLint, NodeJS, and TS minimum version requirements (#8377)
  • 559c0c4 docs: fix missing quotation mark in explicit-member-accessibility.md (#8384)
  • See full diff in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Apr 8, 2024
@dependabot dependabot bot requested review from a team and acronhub and removed request for a team April 8, 2024 05:45
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/typescript-eslint/eslint-plugin-7.0.0 branch from 40d5726 to b0258c4 Compare April 26, 2024 02:58
@kimkim0814 kimkim0814 requested review from kimkim0814 and removed request for acronhub July 31, 2024 09:25
@kimkim0814
Copy link
Member

kimkim0814 commented Jul 31, 2024

6.21.0 から 7.0.0 変更に伴う破壊的変更

bump ESLint, NodeJS, and TS minimum version requirements (typescript-eslint/typescript-eslint#8377)

上記を確認したところ、以下の破壊的変更があることがわかった。

  • 最小限の NodeJS バージョンを v18.18.0 に引き上げ(ESLint v9 の最小バージョンに合わせる)
  • NodeJS 19 のサポートを終了(ESLint v9 と同じ)
  • 最小限の TypeScript バージョンを v4.7.5 に引き上げ
  • 最小限の ESLint バージョンを v8.56.0 に引き上げ
  • @typescript-eslint/utils/eslint-utils から以下の後方互換性ヘルパーを削除
    • getAncestors
    • getCwd
    • getDeclaredVariables
    • getFilename
    • getScope
    • getSourceCode

ref:typescript-eslint/typescript-eslint#8377

qiita-cli 内で確認

  • node のバージョンが18.12.0のためnodeがバージョン変更しないと不可能
  • typescriptは5.4.3のため問題なし
  • eslintは8.5.7のため問題なし
  • 後方互換性ヘルパーを削除について、getFilename にgrepした際に定義されていたが今回の件とは関係ないので問題なし

TODO

  • node のバージョンを18.18.0に上げる

@kimkim0814
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/typescript-eslint/eslint-plugin-7.0.0 branch from b0258c4 to f3c7a54 Compare July 31, 2024 09:47
@kimkim0814
Copy link
Member

@dependabot rebase

Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 6.21.0 to 7.0.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v7.0.0/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/typescript-eslint/eslint-plugin-7.0.0 branch from f3c7a54 to 17e068e Compare December 4, 2024 05:25
Copy link
Member

@kimkim0814 kimkim0814 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nodeのサポートバージョンを #172 でアップグレードした

LGTM!

@kimkim0814 kimkim0814 merged commit c142f56 into main Dec 4, 2024
6 checks passed
@kimkim0814 kimkim0814 deleted the dependabot/npm_and_yarn/typescript-eslint/eslint-plugin-7.0.0 branch December 4, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant