Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add initial layout and components #36

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

chosww
Copy link
Collaborator

@chosww chosww commented Nov 14, 2024

  • Add base layout and styles for home and about pages (projects page is there, but it will have different layout)
  • Implement a header component with UIO Integration
  • Implement collapsable navigation bar depends on screen size
  • Populate mock data to display, later they will be replaced by appropriate collection data

Copy link

cloudflare-workers-and-pages bot commented Nov 20, 2024

Deploying inclusive-standards with  Cloudflare Pages  Cloudflare Pages

Latest commit: a275d04
Status: ✅  Deploy successful!
Preview URL: https://7c4238ee.inclusive-standards.pages.dev
Branch Preview URL: https://feat-layout-and-cards.inclusive-standards.pages.dev

View logs

@chosww chosww changed the title feat: layout and cards feat: add initial layout and components Dec 3, 2024
@chosww chosww added this to the V1 milestone Dec 3, 2024
@chosww chosww requested a review from greatislander December 4, 2024 20:03
Copy link
Member

@greatislander greatislander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @chosww — a number of changes here. Once you've gone through them all, let's meet to discuss.

{% extends "layouts/base.njk" %}

{% block content %}
{% for key, value in sections %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend a different approach to this; the CMS won't work well with this method, and Markdown won't be processed the way you've set this up. Let's discuss.

src/_includes/layouts/base.njk Outdated Show resolved Hide resolved
src/_includes/layouts/base.njk Outdated Show resolved Hide resolved
src/_includes/layouts/projects.njk Show resolved Hide resolved
src/_includes/partials/components/card.njk Outdated Show resolved Hide resolved
src/collections/pages/en/projects.md Outdated Show resolved Hide resolved
src/collections/pages/fr/about.md Outdated Show resolved Hide resolved
src/collections/pages/fr/projects.md Outdated Show resolved Hide resolved
src/collections/pages/en/projects.md Outdated Show resolved Hide resolved
src/index.md Outdated Show resolved Hide resolved
@greatislander greatislander added the enhancement New feature or request label Dec 5, 2024
@greatislander greatislander enabled auto-merge (squash) December 6, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants