-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add composition information #27
base: main
Are you sure you want to change the base?
Conversation
Hi @cindyli : This is almost ready for review, but see my comments in the main description above. I've left it as a draft PR. If you have any use for the composition information, however, it's available as described above. |
@klown, I agree using a script to update Since this script is likely to be run only once to update the file, and the composition information is not expected to change frequently, manual updates might be enough for future changes. When the composition information for the three currently missing symbols becomes available, a manual update might be an easy route too. With that in mind, here are some thoughts:
Let me know what you think. Thanks. |
No longer needed since the script is now a command line tool
The latest version of the code uses
I agree with the removal but for different reasons. With respect to the composition information in the spreadsheet, it sometimes differs from the Blissary. Like the palette rendering code, the script here uses only the Blissary for determining the composition of the symbols. Note that Russell has updated the original spreadsheet on the shared drive following a discussion with him and Hannes. That means that In fact, I'm thinking about deleting all of the tsv material at this point -- the spreadsheet and the associated scripts. The only thing stopping me is that the spreadsheet was used to categorize the symbols as Bliss-characters vs. Bliss-words. That information is available from the Blissary, but I need to talk with Hannes to see if we can access it programatically. With respect to words vs characters, I have discovered additional inconsistencies between the spreadsheet and the Blissary. One set is small and it could be handled by editing The small set of inconsistencies involve four indicators. These are listed as Bliss-words in the spreadsheet, but as Bliss-characters by the Blissary:
There are a lot of other indicators that have the same general form, but are listed as Bliss-characters in both the spreadsheet and by the Blissary. For example, 24677 indicator_(present_action) is a character in both and it's as complicated as 28045 indicator_(thing,definite). I think the Blissary is correct here. The larger set are a number of symbols that are marked as characters in the spreadsheet, but as words in the Blissary. I'm still looking through them, but I think the Blissary is right. For example "12355 aid" is composed of "help+indicator_thing", but is marked as a character in the spreadsheet. Compare that with "14705 help(to)" which is classified as a word in both places but is constructed in a way that is very similar to "12355 aid": Here they are one above the other:
|
WIP
While this does capture and store the composition information for every Bliss symbol in the authorized vocabulary, it's still a little rough. However, the actual composition information is available in
./data/bliss_symbol_explanations.json
in case someone wants access to it../apps/composition-creator/
and is launched by thenpm run serveAppsDemos
task.composingIds
arrays frombliss_symbol_explanations.json
since they are often different from the newcomposition
array.BlissSymbolComposition.md
with the./docs
folder. Is there a better place for this information?composition
array is stored with the symbol. These are also listed by the webapp and inBlissSymbolComposition.md