-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JSON-LD 1.1 exports for NIDM-Results examples #479
Conversation
c11c0e8
to
f77a623
Compare
f77a623
to
c200e00
Compare
…of variable to simplify the code
…efix such as rdfs, nfo, dct
WIP: Remove string & object types to clean up the context
WIP: Display only by the labels & remove prov types
Hi everyone! I think that this long-lasting pull request is now ready to merge. Thank you to @natachaperez for providing so many fixes! No changes have been made to the data model, this PR focuses exclusively on updating our set of examples for NIDM-Results. More specifically, in this PR we:
To ease the conversion, a couple of changes have been made to the turtle templates (used to generate the examples) and the owl file:
Please let us know if you have any comments/feedback. If not, I'll merge at the end of the week. Thanks! |
@cmaumet and @natachaperez - nice work - the one thing i would suggest changing is to first have a PR that generates the context, merge that and then use the purl for that context in the example files. it would be nice to not have really large contexts embedded in the json files. also to generate the cleanest looking files, you may need to tweak |
Hi everyone! Last call: any additional comment on this PR? Or +1's for merge? |
I only have a comment on the removal of the prov assignments. Is the assumption that you'll be able to tell whether the item is an entity, agent, or activity by tracing the term's parents up the tree, so it doesn't need to be explicit? (This is what I'm assuming in NIDM-E). |
@khelm: yes, that's exactly right :) |
I've just updated the context PURL: http://purl.org/nidash/context --now links to--> https://raw.githubusercontent.com/incf-nidash/nidm/master/nidm/nidm-results/terms/nidmr.json. |
This PR converts all our turtle examples into JSON-LD using an automatically generated context (from the OWL file) with type-indexing (JSON-LD 1.1 feature) to ease readability of the NIDM documents.