Assorted minor code improvements #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarikoptic
reviewed
May 8, 2023
| return True | ||
| else: | ||
| return False | ||
| return bool(uuid in self._acquisition_objects) |
There was a problem hiding this comment.
me is curious:
in principle even bool isn't needed, since in would return bool ,right?
Suggested change
| return bool(uuid in self._acquisition_objects) | |
| return uuid in self._acquisition_objects |
or that is really to guarantee it if somehow self._acquisition_objects overloads some operator and returns smth else?
There was a problem hiding this comment.
I was just following what Pylint suggested, though given how mypy is with the return type of == on arbitrary types, I wouldn't be surprised if it complained about the lack of bool() here as well.
|
I am happy to see Python code becoming more pythonic ;) Thank you @jwodder ! Let's proceed. One comment is just for my own sake |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #325.
My thanks to pylint for helping me find these.