Pare down giant comment blocks that largely do what Git already does #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #363 +/- ##
=======================================
Coverage 33.59% 33.59%
=======================================
Files 51 51
Lines 7052 7052
Branches 1784 1784
=======================================
Hits 2369 2369
Misses 4504 4504
Partials 179 179
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
yarikoptic
reviewed
May 5, 2023
| # ***************************************************************************** | ||
| # ***************************************************************************** | ||
| # nidm_query.py | ||
| # License: GPL |
There was a problem hiding this comment.
@dbkeator Please confirm that it is Ok to assume that this file is also under Apache 2 license (per https://github.com/incf-nidash/PyNIDM/blob/master/LICENSE) as the rest of the codebase, or it has to be GPL?
|
Yes, ok with me. |
|
per @dbkeator blessing (Thank you!), let's proceed! |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #325.
@yarikoptic Question: Should the persons listed in the "Coded by" fields removed by this PR be listed in a CONTRIBUTORS file or similar? There are only two such persons listed, David Keator and Ashmita Kumar, both of whom are already listed as authors in the Git history and as contributors on GitHub.