Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add & apply pre-commit and linting #329

Merged
merged 5 commits into from
May 2, 2023
Merged

Add & apply pre-commit and linting #329

merged 5 commits into from
May 2, 2023

Conversation

jwodder
Copy link
Collaborator

@jwodder jwodder commented May 1, 2023

Part of #325.

@jwodder jwodder mentioned this pull request May 1, 2023
35 tasks
@jwodder jwodder marked this pull request as draft May 2, 2023 12:16
@jwodder jwodder marked this pull request as ready for review May 2, 2023 13:43
@jwodder
Copy link
Collaborator Author

jwodder commented May 2, 2023

@yarikoptic Please merge this soon.

@jwodder
Copy link
Collaborator Author

jwodder commented May 2, 2023

@yarikoptic I expect there will be more PRs after this that will need to be merged quickly lest they create merge conflicts with other PRs created around the same time. How should this be handled?

rdfs:label "Phantom Experimental Subject"^^xsd:string .




### Generated by the OWL API (version 3.5.1) http://owlapi.sourceforge.net

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have left autogenerated files without changes -- not familiar yet with turtle format intricately but may be those space indentations are important part of the syntax...? I have tested this one (with trailing spaces removed) at some randomly found http://ttl.summerofcode.be/ -- seems to be ok. I think we can proceed but might need to be ready to revert this part of cleansing

@yarikoptic
Copy link
Member

sorry for the delay. I left a comment, let's proceed

@yarikoptic
Copy link
Member

@yarikoptic I expect there will be more PRs after this that will need to be merged quickly lest they create merge conflicts with other PRs created around the same time. How should this be handled?

I will keep an eye. Worse comes to worse, feel free to merge yourself, I will review later or just build up the chain of PRs basing one on top of another.

@yarikoptic yarikoptic merged commit c4bf3fc into master May 2, 2023
@yarikoptic yarikoptic deleted the pre-commit branch May 2, 2023 16:46
@jwodder jwodder added cleanup internal Changes only affect the internal API labels May 2, 2023
@github-actions
Copy link

🚀 PR was released in v4.0.0 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup internal Changes only affect the internal API released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants