Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: change font-size for modal input descriptions #7650

Open
wants to merge 2 commits into
base: epic/campaigns
Choose a base branch
from

Conversation

glaubersilva
Copy link
Contributor

@glaubersilva glaubersilva commented Dec 16, 2024

Resolves GIVE-2010

Description

This PR changes the font size of the input descriptions used inside the modals on the campaigns page.

Affects

  • The "create campaign" modal
  • The "merge campaign" modal

Visuals

image

image

Testing Instructions

Open the "create campaign" and "merge campaign" modals and make sure the font size for the input descriptions is displayed in the proper size.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@glaubersilva glaubersilva self-assigned this Dec 16, 2024
@glaubersilva glaubersilva changed the title Refactor: change modal description font size Refactor: change font-size for modal input descriptions Dec 16, 2024
@glaubersilva glaubersilva marked this pull request as ready for review December 16, 2024 14:08
Comment on lines +44 to +46
font-size: 0.875rem;
line-height: 1.5;
margin-bottom: 0.4rem;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glaubersilva Why aren't we using the design system for these?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants