Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: adjust Campaign settings page styles #7646

Draft
wants to merge 14 commits into
base: epic/campaigns
Choose a base branch
from

Conversation

JoshuaHungDinh
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh commented Dec 11, 2024

Resolves GIVE-2030

Description

This PR include wrapper elements around the upload & editor components within the Campaign settings page & includes adjustments to the pages stylesheet.

Some of these changes include but are not limited to:

  • Consistent spacing between field inputs, descriptions and labels.
  • Padding adjustments on the setting containers.
  • Font weight & size adjustments.
  • Replacing some styles with the design system.
  • Spacing on the toggle container & its revealed element within the Campaign Details setting .

Affects

Campaign page > Settings tab

Visuals

https://www.loom.com/share/bc171b4104194358a48e4d4ab2e38d00?sid=57ec6aa4-a82e-46fa-ad0b-2824fae22540

Testing Instructions

N/A

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@JoshuaHungDinh JoshuaHungDinh changed the base branch from develop to epic/campaigns December 11, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant