Refactor: migrate v2 forms to campaigns and add upgraded forms as campaign not-default forms #7645
+183
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glaubersilva
changed the title
kjohnson
reviewed
Dec 12, 2024
| /** | ||
| * Excluded upgraded V2 forms as their corresponding V3 version will be used to create the campaign - later the V2 form will be added to the proper campaign as a non-default form through the addUpgradedV2FormToCampaign() method. | ||
| */ | ||
| $upgradedFormsIds = $this->getUpgradedV2FormsIds(); |
There was a problem hiding this comment.
Could this be refactored to a join of the meta with a "where not"? Or do we need a second query?
| * | ||
| * @see https://wordpress.org/documentation/article/post-status/#auto-draft | ||
| */ | ||
| $query->where('forms.post_status', 'auto-draft', '!='); |
There was a problem hiding this comment.
I think this is conflating two different things. We do need to exclude auto-draft as a status, but I don't think that relates in any way to a form being "upgraded" (as stated in the comment above).
| @@ -19,6 +20,8 @@ final class MigrateFormsToCampaignFormsTest extends TestCase | |||
|
|
|||
| /** | |||
| * @unreleased | |||
| * | |||
| * @throws Exception | |||
| */ | |||
| public function testCreatesParentCampaignForDonationForm() | |||
There was a problem hiding this comment.
@glaubersilva can you add a new test to cover V2 forms that are not upgraded?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves GIVE-2032
Description
This PR makes the migrations of Forms to Campaigns also consider V2 forms. It also fixed a problem that was preventing forms with the upgraded status from being associated with campaigns as not-default forms in certain scenarios.
Affects
The migrations of Forms to Campaigns.
Visuals
https://www.loom.com/share/7bf0d4727f944c0da29fd0df9219d7bc?sid=2b9f341f-c61a-4f13-b088-b8600b09afab
Testing Instructions
Pre-review Checklist
@unreleasedtags included in DocBlocks