Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: make entity prop optional #7644

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Fix: make entity prop optional #7644

merged 1 commit into from
Dec 10, 2024

Conversation

alaca
Copy link
Member

@alaca alaca commented Dec 10, 2024 •
edited
Loading

Description

This PR resolves the issue where the entity prop was required for the DonationFormsListTable component outside the Campaign context.

Affects

DonationFormsListTable component

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Self Review of code and UX completed

@alaca alaca requested a review from JasonTheAdams December 10, 2024 12:31
JasonTheAdams
JasonTheAdams approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@JasonTheAdams JasonTheAdams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional and a bonus type! Thanks, @alaca!

@alaca alaca merged commit c9c3e4f into epic/campaigns Dec 10, 2024
20 checks passed
@alaca alaca deleted the fix/make-entity-prop-optional branch December 10, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonTheAdams JasonTheAdams JasonTheAdams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alaca @JasonTheAdams