Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: use DonationForm model to create default campaign form #7638

Conversation

JoshuaHungDinh
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh commented Dec 2, 2024

Description

This PR replaces the factory method used while creating a default campaign with the DonationForm model.

Affects

Creating campaigns with a zip.

Visuals

Screenshot 2024-12-03 at 5 35 19 AM

Testing Instructions

  • Verify you can create a campaign from the zip file without error.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Self Review of code and UX completed

@JoshuaHungDinh JoshuaHungDinh changed the base branch from develop to epic/campaigns December 2, 2024 20:38
@JoshuaHungDinh JoshuaHungDinh changed the title Refactor: use DonationForm model to create default campaign Refactor: use DonationForm model to create default campaign form Dec 3, 2024
@JoshuaHungDinh JoshuaHungDinh marked this pull request as ready for review December 6, 2024 08:29
@JoshuaHungDinh JoshuaHungDinh merged commit 899fa1b into epic/campaigns Dec 9, 2024
20 checks passed
@JoshuaHungDinh JoshuaHungDinh deleted the refactor/replace-create-default-campaign-factory-method branch December 9, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants