-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: adjust Campaign overview tab styles #7636
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaHungDinh
changed the title
Fix/give 2011 campaign tabs
Fix: adjust Campaign overview tab styles
Dec 2, 2024
JoshuaHungDinh
force-pushed
the
fix/GIVE-2011-campaign-tabs
branch
from
December 9, 2024 20:31
d0fa19e
to
7d8bd6f
Compare
JoshuaHungDinh
force-pushed
the
fix/GIVE-2011-campaign-tabs
branch
3 times, most recently
from
December 11, 2024 10:12
15b9828
to
5cd2afb
Compare
jdghinson
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves GIVE-2029
Description
This PR includes the following UI changes to the Campaign overview tabs:
Forms
tab container padding to keep alignment with title.Forms
page content spans full width and requires specific styling.givewp-neutral
font colors for active/hover state.Affects
Visuals
https://www.loom.com/share/cb3e7695f0dc46a4a4629f94c4559ccf?sid=2e31436f-4aae-4e95-b8e4-66964e1001a2
Testing Instructions
Pre-review Checklist