Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: adjust Campaign overview tab styles #7636

Merged
merged 22 commits into from
Dec 11, 2024

Conversation

JoshuaHungDinh
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh commented Dec 2, 2024

Resolves GIVE-2029

Description

This PR includes the following UI changes to the Campaign overview tabs:

  • Update padding on each tab.
  • Included line-height.
  • Expand hover border to spread width of tab.
  • Set a fixed width on tabs to maintain size, while font-weight is changed on hover.
  • Specify Forms tab container padding to keep alignment with title. Forms page content spans full width and requires specific styling.
  • Use font-weight 500 on hover.
  • Use givewp-neutral font colors for active/hover state.
  • Update spacing & alignment in breadcrumb.
  • Update gap in title, badge, campaign buttons container.
  • Additional header font changes.
  • Header element vertical spacing.

Affects

  • Campaign overview tabs

Visuals

https://www.loom.com/share/cb3e7695f0dc46a4a4629f94c4559ccf?sid=2e31436f-4aae-4e95-b8e4-66964e1001a2

Testing Instructions

  • View the Campaign overview page.
  • Hover over each tab, ensure that the tab widths do not change size due to the font weight becoming bold.
  • While hovering the first tab, verify the bottom border is aligned with the title and page content.
  • Select each tab and verify the page content is displayed properly and aligned.
  • Ensure selecting the forms tab does not have any unintended sideeffects.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@JoshuaHungDinh JoshuaHungDinh changed the title Fix/give 2011 campaign tabs Fix: adjust Campaign overview tab styles Dec 2, 2024
@JoshuaHungDinh JoshuaHungDinh marked this pull request as ready for review December 9, 2024 02:30
@JoshuaHungDinh JoshuaHungDinh force-pushed the fix/GIVE-2011-campaign-tabs branch from d0fa19e to 7d8bd6f Compare December 9, 2024 20:31
@JoshuaHungDinh JoshuaHungDinh force-pushed the fix/GIVE-2011-campaign-tabs branch 3 times, most recently from 15b9828 to 5cd2afb Compare December 11, 2024 10:12
Copy link
Contributor

@jdghinson jdghinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@JoshuaHungDinh JoshuaHungDinh merged commit 3b8580c into epic/campaigns Dec 11, 2024
20 checks passed
@JoshuaHungDinh JoshuaHungDinh deleted the fix/GIVE-2011-campaign-tabs branch December 11, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants