Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: display uploaded donor avatar on donor wall #7620

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Feature: display uploaded donor avatar on donor wall #7620

merged 1 commit into from
Nov 14, 2024

Conversation

JasonTheAdams
Copy link
Contributor

@JasonTheAdams JasonTheAdams commented Nov 14, 2024 •
edited
Loading

Description

The donor has had the ability to upload a profile image for years, since the Donor Dashboard was introduce. But the Donor Wall was never updated to make use of this — which is a bummer!

This PR has the Donor Wall check for an uploaded image and prioritizes it above the Gravatar image if available.

Affects

The donor dashboard shortcode template

Visuals

Uploaded in donor dashboard:
image

Showing in Donor wall:
image

Testing Instructions

  1. Go to the Donor Dashboard and upload an image
  2. Save your profile
  3. Go to a donor wall showing that user, and see if the image shows up
  4. Double-check that removing the image doesn't break anything

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

pauloiankoski
pauloiankoski approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@pauloiankoski pauloiankoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch. LGTM.

@JoshuaHungDinh
Copy link
Contributor

@JasonTheAdams Nice photo, they look like water-benders from Avatar. 😄

alaca
alaca approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@alaca alaca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@kjohnson
Copy link
Member

Nice photo, they look like water-benders from Avatar. 😄

Came here to say the same!

@jonwaldstein
Copy link
Contributor

@JasonTheAdams still got it 🥇

@JasonTheAdams
Copy link
Contributor Author

@JoshuaHungDinh I always keep this bad boy close: 😆

going-crazy

@JasonTheAdams JasonTheAdams merged commit 13cc82e into develop Nov 14, 2024
20 checks passed
@JasonTheAdams JasonTheAdams changed the title Feature: displays uploaded donor avatar on donor wall Feature: display uploaded donor avatar on donor wall Nov 14, 2024
@JasonTheAdams JasonTheAdams deleted the feature/donor-wall-avatar branch November 14, 2024 16:40
rickalday
rickalday reviewed Nov 18, 2024
View reviewed changes
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickalday rickalday rickalday left review comments

@alaca alaca alaca approved these changes

@pauloiankoski pauloiankoski pauloiankoski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@JasonTheAdams @JoshuaHungDinh @kjohnson @jonwaldstein @rickalday @pauloiankoski @alaca