Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove unnecessary error message when selecting the initial goal while creating a new campaign #7610

Merged

Conversation

glaubersilva
Copy link
Contributor

@glaubersilva glaubersilva commented Nov 6, 2024

Resolves GIVE-1339

Description

This PR removes the unnecessary validation and sets the goal input, in the same way, using the settings tab from the campaigns details page.

Affects

The creation of new campaigns.

Visuals

Testing Instructions

  1. In the modal for creating a new campaign select the "Amount raised" goal type option first;
  2. Select any other option after the previous step;
  3. Repeat the step #1;
  4. Fill the input with the goal;
  5. Click on the “Continue” button;
  6. No error should be thrown next to the input.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@glaubersilva glaubersilva self-assigned this Nov 6, 2024
@glaubersilva glaubersilva changed the title Fix: remove unnecessary error message when selecting initial goal on new campaign creation modal Fix: remove unnecessary error message when selecting the initial goal while creating a new campaign Nov 6, 2024
@glaubersilva glaubersilva marked this pull request as ready for review November 6, 2024 17:55
Copy link
Member

@alaca alaca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@glaubersilva glaubersilva merged commit 1dc7949 into epic/campaigns Nov 7, 2024
20 checks passed
@glaubersilva glaubersilva deleted the fix/initial-goal-throws-error-GIVE-1339 branch November 7, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants