Feature: extract the feature flag for option-based form editor from campaigns domain into the core #7593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glaubersilva
changed the title
|
@jonwaldstein Gentle ping here to remind you about the double-check that we talked another day related to the settings options audit that should be visible only when the Option-based form editor is enabled. So, when you have the chance please let me know if we have hidden all necessary v2 options or if something was left behind. |
jonwaldstein
requested changes
Oct 31, 2024
There was a problem hiding this comment.
@glaubersilva this is great! I noted some changes to settings that have changed since my last audit 😄
src/FeatureFlags/OptionBasedFormEditor/Settings/DefaultOptions.php
Outdated
Show resolved
Hide resolved
src/FeatureFlags/OptionBasedFormEditor/Settings/DefaultOptions.php
Outdated
Show resolved
Hide resolved
|
@jonwaldstein I implemented the changes based on your last audit. Let me know if there is something else. |
jonwaldstein
requested changes
Nov 14, 2024
|
@jonwaldstein This is ready for a new review. |
jonwaldstein
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves GIVE-1345
Description
This PR extracts from the campaigns epic branch the feature to enable or disable the Option-Based Form editor. The main goal here is to be able to release this new feature as soon as possible, without the need to wait until the Campaigns project is finished.
This PR adds a new option to the
Give > Settings > Advancedpage that allows users to enable or disable the Option-Based Form Editor. This new option is enabled by default if the website has any Option-Based forms on DB and disabled by default if it has only Visual Form Builder forms on DB.Affects
The "Settings" page and the "Switch to Legacy View" button from the "All Forms" page.
Visuals
Demo video:
https://www.loom.com/share/6b1063475387458a9621a24c920b8077?sid=914ffc3f-19a2-4159-be82-ed2868e90eca
Testing Instructions
Go to the
Give > Settings > Advancedpage to enable or disable theOption-Based Form Editoroption and make sure the expected behaviors occur.Expected behaviors with the legacy editor disabled:
Expected behaviors with the legacy editor enabled:
Pre-review Checklist
@unreleasedtags included in DocBlocks