Refactor: Change to use the selected default period in notice #7434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaHungDinh
approved these changes
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves GIVE-822
Description
Under certain conditions, due to a combination of Give Recurring settings, a notice is shown below the Amount block in the VFB, representing the same message users will see in the Donation Form. This notice informs that the donation will repeat every X periods. Currently, that message always uses the first option label. This pull request changes that behavior to use the selected default period as the source for the period label. With that, was necessary to add an extra conditional to not show the notice when the default option is set to "One-time".
Affects
Recurring settings in the Amount block
Visuals
CleanShot.2024-07-03.at.18.20.08.mp4
Testing Instructions
Make sure the recurring message is still being displayed correctly in both VFB and Donation Form.
Pre-review Checklist
@unreleasedtags included in DocBlocks