Refactor: Prevent File Upload description from triggering file selection modal #7433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves GIVE-820
Description
The File Upload template is entirely clickable, triggering the file selection modal. This issue is caused by a label element wrapping the entire component. This pull request changes it by unwrapping the label element, keeping it only around the label text while still allowing it to trigger the file selection modal. The difference is that now, clicking the description text will not activate the modal, making this template consistent with how other fields behave.
Affects
File input template
Visuals
https://github.com/impress-org/givewp/assets/3921017/2e66c450-23a0-448c-99b1-df4b175dd8b0
Clicking the input, then the label, the description
Testing Instructions
Make sure the input field works just like before, except it will not trigger the file selection modal when clicking on the description text.
Pre-review Checklist
@unreleasedtags included in DocBlocks