Fix fatal error in give-export-donations-exporter.php #7417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The meta 'razorpay_donation_response' is an array. Must be serialized to avoid a fatal error: TypeError: Uncaught TypeError: substr(): Argument impress-org#1 ($string) must be of type string, array given in /var/www/html/wordpress/wp-content/plugins/give/includes/admin/tools/export/give-export-donations-exporter.php:684
|
@glaubersilva since you are working on razorpay, could you review this please? |
There was a problem hiding this comment.
@Genevieve-K Thanks for the fix!
I wasn't able to reproduce this bug on PHP 7.4.3 but was able to reproduce it with PHP 8.1.23 and could confirm that your fix is working as expected.
The code looks good to me, but I noticed a minor thing related to a missing @unreleased tag. I left a comment with more details about it. Let me know if you have any questions!
glaubersilva
approved these changes
Jul 10, 2024
kjohnson
pushed a commit
that referenced
this pull request
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves GIVE-958
The meta 'razorpay_donation_response' is an array. Must be serialized to avoid a fatal error:
TypeError: Uncaught TypeError: substr(): Argument #1 ($string) must be of type string, array given in /var/www/html/wordpress/wp-content/plugins/give/includes/admin/tools/export/give-export-donations-exporter.php:684To test: