Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve the styling of the anonymous donation checkbox description #7413

Merged
merged 5 commits into from
Jul 3, 2024

Conversation

JoshuaHungDinh
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh commented Jun 14, 2024

Resolves: GIVE-814

Description

This PR introduces style changes to align the description of the anonymous donation checkbox with its label. I've also updated the color and size to match between the Build & Design previews.

Affects

Anonymous Donation Checkbox

Visuals

Previous view:

previous

Updated view:

build design

Testing Instructions

  • add an anonymous donation checkbox to a v3 form.
  • check both build & design previews to verify that the bottom description is now aligned with the top label.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@JoshuaHungDinh JoshuaHungDinh marked this pull request as ready for review June 17, 2024 14:52
Copy link
Contributor

@pauloiankoski pauloiankoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please, make sure this pass through design review too. ;)

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests.

@JoshuaHungDinh JoshuaHungDinh merged commit 84d4b28 into develop Jul 3, 2024
4 checks passed
@JoshuaHungDinh JoshuaHungDinh deleted the refactor/anonymous-donation-block-styles branch July 3, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants