Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: goal date settings #7388

Merged
merged 1 commit into from
May 14, 2024
Merged

Fix: goal date settings #7388

merged 1 commit into from
May 14, 2024

Conversation

alaca
Copy link
Member

@alaca alaca commented May 14, 2024 •
edited
Loading

Description

This PR resolves the issue with goal date settings.

Pre-review Checklist

@alaca alaca requested a review from jonwaldstein May 14, 2024 16:15
jonwaldstein
jonwaldstein approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@jonwaldstein
Copy link
Contributor

Build for QA: https://github.com/impress-org/givewp/actions/runs/9083220341

rickalday
rickalday approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed QA tests.

@jonwaldstein jonwaldstein merged commit 712b358 into develop May 14, 2024
20 checks passed
@jonwaldstein jonwaldstein deleted the fix/goal-date-settings-GIVE-781 branch May 14, 2024 19:32
kjohnson pushed a commit that referenced this pull request Aug 21, 2024
@alaca @kjohnson
Fix: goal date settings (#7388)
d35992e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonwaldstein jonwaldstein jonwaldstein approved these changes

@rickalday rickalday rickalday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alaca @jonwaldstein @rickalday