Refactor: limit description length to 120 chars and re-style them #7377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaHungDinh
approved these changes
Apr 29, 2024
pauloiankoski
merged commit 27cd65b
into
epic/donation-amount-level-descriptions
20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves GIVE-700
Description
This pull request sets a limit for level descriptions to 120 characters. Additionally, levels are now styled in a way that for long descriptions, their buttons are top-aligned.
FYI: In this PR, we are only setting the max length. All related code has been added to the
OptionsPanelcomponent as that's the responsible for controlling that.Affects
Amount level descriptions
Visuals
Pre-review Checklist
@unreleasedtags included in DocBlocks