Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: remove input border on focus #7349

Merged
merged 6 commits into from
Apr 18, 2024

Conversation

JoshuaHungDinh
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh commented Apr 10, 2024

Resolves GIVE-637

Description

This PR removes the default border on all inputs for all templates while the input is selected. While selected we have another style that outlines these inputs with the primary color chosen on the form, if the original border is not removed it can still visible resulting in two colored borders. As seen below.
image

Reference: https://lw.slack.com/archives/C04SLRDD9CK/p1712671026808389

Affects

styling of the VFB input fields on all templates

Visuals

Screen.Recording.2024-04-09.at.1.10.53.PM.mov

Testing Instructions

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@JoshuaHungDinh JoshuaHungDinh marked this pull request as ready for review April 10, 2024 20:38
Copy link
Contributor

@pauloiankoski pauloiankoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you completely remove the border, the element moves slightly. You might notice it "blinking".

What do you think about changing the border color instead of removing it, like in:

border-color: var(--form-element-focus-color);

@JoshuaHungDinh
Copy link
Contributor Author

@pauloiankoski Nice catch, it looked it little to different to me while changing the border-color. Are you good with me making it transparent instead of removing it? It will solve the blinking issue. 7baec5c

@pauloiankoski
Copy link
Contributor

Well, that's not a technical question. @jdghinson would you mind to give your input here? In short, the question is: should we turn the current border "green" or transparent on focus. Additionally to it, the traditional box-shadow will also be displayed. Whatever "The Boss" answers, I'm cool with!

Transparent Colored
CleanShot 2024-04-15 at 17 38 34 CleanShot 2024-04-15 at 17 40 06

@jdghinson
Copy link
Contributor

@pauloiankoski The transparent looks cleaner

Cc: @JoshuaHungDinh

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests.

@JoshuaHungDinh JoshuaHungDinh merged commit fbfa45d into develop Apr 18, 2024
20 checks passed
@JoshuaHungDinh JoshuaHungDinh deleted the refactor/input-focus-border branch April 18, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants