Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Set content for missing title in event tickets template #7323

Open
wants to merge 3 commits into
base: epic/event-tickets-follow-up-GIVE-371
Choose a base branch
from

Conversation

pauloiankoski
Copy link
Contributor

Resolves #

Description

Per designs, we have a title above the ticket list in the Event Tickets template, but due to a mistake in its implementation, it was being rendered as an empty tag. This pull request corrects this issue by directly setting its content in the template. As a consequence of this new implementation, all references to the ticketLabel as an attribute are being removed.

Visuals

CleanShot 2024-03-21 at 20 53 02

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

Copy link

github-actions bot commented May 6, 2024

This PR is stale because it has been open 45 days with no activity. Stale PRs will NOT be automatically closed.

@github-actions github-actions bot added the Stale label May 6, 2024
Copy link
Member

@kjohnson kjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I resolved the merge conflicts and tested the build locally.

@kjohnson
Copy link
Member

kjohnson commented Dec 6, 2024

@github-actions github-actions bot removed the Stale label Dec 7, 2024
@jonwaldstein
Copy link
Contributor

@kjohnson thanks for reviving this! can you send it off to QA please?
cc: @pauloiankoski

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants