Setup strauss installar script to auto download and use latest release

[ravinderk]

Resolves GIVE-2056

Description

This pull request sets a bash script to automatically use the latest release of strauss package.

Testing Instructions

• You should be able to successfully run composer install
• strauss.phar should install when
  • bin/strauss.phar does not exist
  • bin/strauss-version.txt does not exist
  • staruss version in bin/strauss-version.txt does not match latest release.
• composer install should always install latest release of strauss

Note: you can run bin/strauss-install.sh for testing.

Pre-review Checklist

• Acceptance criteria satisfied and marked in related issue
• Relevant @unreleased tags included in DocBlocks
• Includes unit tests
• Reviewed by the designer (if follows a design)
• Self Review of code and UX completed

[jonwaldstein]

@ravinderk i'm hesitant to always install the latest release of strauss without testing incremental versions in our workflow.
Is there any reason you would be confident enough to let that automation happen to receive the latest version or do we think there are possibilities of side effects that could go unnoticed without proper testing of each version?

[ravinderk]

@ravinderk i'm hesitant to always install the latest release of strauss without testing incremental versions in our workflow. Is there any reason you would be confident enough to let that automation happen to receive the latest version or do we think there are possibilities of side effects that could go unnoticed without proper testing of each version?

@jonwaldstein I locked release version to 0.16.0:7ad261c, that means bash script will only install specific version and clear cached version from bash automatically.

[jonwaldstein]

@ravinderk okay, thanks that makes sense 😄

@JasonTheAdams I would appreciate your eyes on this as well - since you were the one who setup strauss 🧙.

[JasonTheAdams]

It seems like this is taking what's currently a single line of inline bash and breaking it out into a bash script. Is the current line not doing something? Why not just change the inline script to be https://github.com/BrianHenryIE/strauss/releases/download/0.16.0/strauss.phar?

[ravinderk]

It seems like this is taking what's currently a single line of inline bash and breaking it out into a bash script. Is the current line not doing something? Why not just change the inline script to be https://github.com/BrianHenryIE/strauss/releases/download/0.16.0/strauss.phar?

@JasonTheAdams I added an extra feature in the bash script. The cached bin/strauss.phar will be replaced in bin/ if the current version does not match. That means we will have the same version across team.

[JasonTheAdams]

Got it, @ravinderk! I see the value and I like it!

Rather than storing the version in a file, I suggest using php strauss.phar --version, which will output something like:

strauss 0.14.0

You can use a little regex to easily parse the version from that line. As a note, I put in a request for a plain version flag.

[ravinderk]

Got it, @ravinderk! I see the value and I like it!

Rather than storing the version in a file, I suggest using php strauss.phar --version, which will output something like:

strauss 0.14.0

You can use a little regex to easily parse the version from that line. As a note, I put in a request for a plain version flag.

@JasonTheAdams version command output is not reliable at this moment and I created an issue on their repository BrianHenryIE/strauss#90. For this reason, I am using a txt file to store the version.

[JasonTheAdams]

@ravinderk According to that Issue this is working in the PHAR. I just tested it in 0.14.0 and it worked fine, too.

[ravinderk]

@ravinderk According to that Issue this is working in the PHAR. I just tested it in 0.14.0 and it worked fine, too.

@JasonTheAdams I refactored logic to use version to get strauss library version- c942413

[JasonTheAdams]

Thanks! I like it! I can definitely see this avoiding some strange issues in the future. 👍

[jonwaldstein]

Build for QA: https://github.com/impress-org/givewp/actions/runs/8508557651

[jonwaldstein]

The github action for generating a zip is failing on this PR due to some permission issue with the vendor-prefixed directory https://github.com/impress-org/givewp/actions/runs/8524271225/job/23348497486

Anyone have an idea what's going on?

[jonwaldstein]

The github action for generating a zip is failing on this PR due to some permission issue with the vendor-prefixed directory https://github.com/impress-org/givewp/actions/runs/8524271225/job/23348497486

Anyone have an idea what's going on?

@JasonTheAdams @ravinderk we have a permission issue with the vendor-prefixed folder ☝️

[ravinderk]

@jonwaldstein I am not sure what is an issue with the rsync command and directory permission. We need to debug the GitHub action, or we can update the workflow to set the correct permission to the vendor-prefixed directory.

Can you take of this?

cc @JasonTheAdams

[jonwaldstein]

@ravinderk yeah, i'm confused why it's only failing from permissions issues in this PR though

[jonwaldstein]

The plugin zip is still failing for this which should be resolved before merging.

https://github.com/impress-org/givewp/actions/runs/9682069602/job/26714974478

[github-actions]

This PR is stale because it has been open 45 days with no activity. Stale PRs will NOT be automatically closed.

[jonwaldstein]

Apparently Strauss 0.16.0 introduced some permission issue BrianHenryIE/strauss#104 and was fixed in 0.19.2. We can try updating to the latest at time of writing this which would be 0.20.0

[jonwaldstein]

I attempted to update to 0.20.0 but now we have another permission issue:

[jonwaldstein]

Updated to 0.20.1 with the permissions fix from @defunctl and we're back in business!

https://github.com/impress-org/givewp/actions/runs/12304079021