-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Offline donations gateway v3 compatibility #6919
Feature: Offline donations gateway v3 compatibility #6919
Conversation
@jonwaldstein This is ready for review! Happy to hop on a call to review together if you feel that would speed things up. |
@JasonTheAdams i'm getting a bunch of errors when running |
@jonwaldstein Are you able to help with that? How do I know which version to use? |
The version of the Yes I can help |
@JasonTheAdams fyi there's some discrepencies between the latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, left a few comments. You will also want to add a migration for the form settings to block attributes.
src/PaymentGateways/Gateways/Offline/Actions/DisableGatewayWhenDisabledPerForm.php
Show resolved
Hide resolved
...r/resources/js/form-builder/src/components/settings/PopoverContentWithTemplateTags/index.tsx
Outdated
Show resolved
Hide resolved
@jonwaldstein Your appreciated feedback has been addressed and (thanks to your guard suggestion) all tests are passing. This is ready for another review! |
@JasonTheAdams are you going to update this PR with the migration as well? |
Ah yes, good point! I'll do that now! |
@jonwaldstein I added the migration code: 22fff11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! ready for QA 💸
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed manual QA tests.
Description
This PR is a rebuild of the Offline gateway to make use of the Gateway API and be v2 + v3 compatible. It cleans up a bunch of the old code and should port everything over nicely. The ID and everything should be preserved such that it's full backwards-compatible.
Note, since there's now a Billing Address block, the billing address settings don't do anything anymore on v3 forms. It should still work on v2 forms, though.
Affects
The offline donations gateway
Visuals
In the donation form
Settings in form builder
Testing Instructions
Make sure the Offline gateway works with v2 and v3 forms. Make sure to test out the various settings and emails related to offline.
Pre-review Checklist
@unreleased
tags included in DocBlocks