-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: improve login expired message and clean up storage system #6911
Conversation
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is breaking the form preview feature due to a change in how the storageData
is being localized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good to go!
Re-running failed tests due to intermittent date comparison issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed manual QA tests.
Description
The primary goal of this is to provide a more meaningful message to users in the form builder when they got to save and their session has expired. We can later explore a UI to allow the user to log in and not lose their place, but for now we're starting with a good message.
While working on this, I also realized we have some old code for a storage system that no longer works — due to deep WP integration — and cleaned up the storage system a bit.
Affects
The system for saving, loading, and previewing within the form builder.
Testing Instructions
Two things to test. First, make sure that the form builder still works, especially saving and previewing forms.
Second, do the following to simulate an expired login session:
Pre-review Checklist
@unreleased
tags included in DocBlocks