Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: improve login expired message and clean up storage system #6911

Merged
merged 5 commits into from
Sep 1, 2023

Conversation

JasonTheAdams
Copy link
Contributor

@JasonTheAdams JasonTheAdams commented Sep 1, 2023

Description

The primary goal of this is to provide a more meaningful message to users in the form builder when they got to save and their session has expired. We can later explore a UI to allow the user to log in and not lose their place, but for now we're starting with a good message.

While working on this, I also realized we have some old code for a storage system that no longer works — due to deep WP integration — and cleaned up the storage system a bit.

Affects

The system for saving, loading, and previewing within the form builder.

Testing Instructions

Two things to test. First, make sure that the form builder still works, especially saving and previewing forms.

Second, do the following to simulate an expired login session:

  1. Open the form builder
  2. Open the JS console
  3. Press cmd+shift+P to open up a command console and type in "Clear site data", and run the command
  4. Make some change in the form
  5. Click "update" to save the form
  6. An alert should pop up with the new message

Pre-review Checklist

  • Relevant @unreleased tags included in DocBlocks
  • Self Review of code and UX completed

@kjohnson kjohnson self-requested a review September 1, 2023 16:26
@kjohnson
Copy link
Member

kjohnson commented Sep 1, 2023

The form-id query string on the preview URL is being omitted, which is breaking previews.

Copy link
Member

@kjohnson kjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is breaking the form preview feature due to a change in how the storageData is being localized.

Copy link
Member

@kjohnson kjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go!

@kjohnson
Copy link
Member

kjohnson commented Sep 1, 2023

Re-running failed tests due to intermittent date comparison issues.

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests.

@JasonTheAdams JasonTheAdams merged commit 2084710 into epic/givewp-3.0 Sep 1, 2023
21 checks passed
@JasonTheAdams JasonTheAdams deleted the feature/cookie-message branch September 1, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants