Fix: return donation billing address in Stripe Payment Element Gateway (

#7395) Co-authored-by: Jon Waldstein <[email protected]> Co-authored-by: Jon Waldstein <[email protected]>
impress-org · Jun 3, 2024 · 7a2a8a5 · 7a2a8a5
1 parent da11d76
commit 7a2a8a5
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 2 deletions.
diff --git a/...ymentGateways/Gateways/Stripe/StripePaymentElementGateway/StripePaymentElementGateway.php b/...ymentGateways/Gateways/Stripe/StripePaymentElementGateway/StripePaymentElementGateway.php
@@ -89,6 +89,8 @@ public function formSettings(int $formId): array
     }
 
     /**
+     * @unreleased updated to send billing address details to Stripe
+     * @since 3.0.0
      * @inheritDoc
      * @throws ApiErrorException
      */
@@ -144,7 +146,15 @@ public function createPayment(Donation $donation, $gatewayData): GatewayCommand
             'returnUrl' => $stripeGatewayData->successUrl,
             'billingDetails' => [
                 'name' => trim("$donation->firstName $donation->lastName"),
-                'email' => $donation->email
+                'email' => $donation->email,
+                'address' => [
+                    'city' => $donation->billingAddress->city,
+                    'country' => $donation->billingAddress->country,
+                    'line1' => $donation->billingAddress->address1,
+                    'line2' => $donation->billingAddress->address2,
+                    'postal_code' => $donation->billingAddress->zip,
+                    'state' => $donation->billingAddress->state,
+                ],
             ],
         ]);
     }

diff --git a/...ymentGateways/Gateways/Stripe/StripePaymentElementGateway/stripePaymentElementGateway.tsx b/...ymentGateways/Gateways/Stripe/StripePaymentElementGateway/stripePaymentElementGateway.tsx
@@ -89,6 +89,10 @@ interface StripeGateway extends Gateway {
     settings?: StripeSettings;
 }
 
+/**
+ * @unreleased updated afterCreatePayment response type to include billing details address
+ * @since 3.0.0
+ */
 const stripePaymentElementGateway: StripeGateway = {
     id: 'stripe_payment_element',
     initialize() {
@@ -135,6 +139,14 @@ const stripePaymentElementGateway: StripeGateway = {
             billingDetails: {
                 name: string;
                 email: string;
+                address?: {
+                    city?: string;
+                    country?: string;
+                    line1?: string;
+                    line2?: string;
+                    postal_code?: string;
+                    state?: string;
+                }
             };
         };
     }): Promise<void> {

diff --git a/tests/Feature/Gateways/Stripe/StripePaymentElement/TestStripePaymentElementGateway.php b/tests/Feature/Gateways/Stripe/StripePaymentElement/TestStripePaymentElementGateway.php
@@ -57,6 +57,7 @@ public function testFormSettingsShouldReturnData()
     }
 
     /**
+     * @unreleased updated to send billing address details to Stripe
      * @since 3.0.0
      *
      * @throws \Give\Framework\Exceptions\Primitives\Exception
@@ -140,7 +141,15 @@ public function testCreatePaymentShouldReturnRespondToBrowserCommand()
                 'returnUrl' => $gatewayData['successUrl'],
                 'billingDetails' => [
                     'name' => trim("$donation->firstName $donation->lastName"),
-                    'email' => $donation->email
+                    'email' => $donation->email,
+                     'address' => [
+                        'city' => $donation->billingAddress->city,
+                        'country' => $donation->billingAddress->country,
+                        'line1' => $donation->billingAddress->address1,
+                        'line2' => $donation->billingAddress->address2,
+                        'postal_code' => $donation->billingAddress->zip,
+                        'state' => $donation->billingAddress->state,
+                    ],
                 ]
             ])
         );