Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sending unique ping data to ensure response is related to request #55

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Sending unique ping data to ensure response is related to request #55

wants to merge 1 commit into from

Conversation

digartner
Copy link
Contributor

No description provided.

@digartner
Copy link
Contributor Author

Related to #28

According to that issue, some redis connections become "corrupted" due to time outs. Subsequent calls to get() can return results from previous commands.
This change ensures that when we call PING, we don't accidentally accept a PONG response from a corrupted connection.

@garrensmith
Copy link
Collaborator

@digartner could you change this to point to the new main and then we can merge it in.
Is it possible to write a test for this?

@aqrln aqrln changed the base branch from master to main October 30, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@digartner @garrensmith @Isaac-at-here