-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new params to JSON schemas. #544
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #544 +/- ##
=======================================
Coverage 49.00% 49.00%
=======================================
Files 164 164
Lines 7816 7816
Branches 1063 1063
=======================================
Hits 3830 3830
Misses 3977 3977
Partials 9 9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes that you've made all look correct, BUT we want a v2 of the kevinhall.json
schema, not a modified v1. If we just change v1, then all the existing config files out there (including the ones in the examples repo) will start failing validation, even though they're well formed files (for old versions of HGPS, anyway).
You need to do what I did with the staticlinear.json
schema and copy it over to the v2 folder, then update any $ref
properties to point to the right subschemas (in the v1 folder) before making changes.
You'll also need a v2 of dynamic.json
(see what I did for static.json
for an example).
Ah I see. Done 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Resolves #543
Adds missing new params to KH and staticlinear JSON schemas.