Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new params to JSON schemas. #544

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Add new params to JSON schemas. #544

merged 3 commits into from
Oct 4, 2024

Conversation

jamesturner246
Copy link
Contributor

Resolves #543

Adds missing new params to KH and staticlinear JSON schemas.

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.00%. Comparing base (5721fe0) to head (90c606d).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #544   +/-   ##
=======================================
  Coverage   49.00%   49.00%           
=======================================
  Files         164      164           
  Lines        7816     7816           
  Branches     1063     1063           
=======================================
  Hits         3830     3830           
  Misses       3977     3977           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamesturner246 jamesturner246 mentioned this pull request Oct 3, 2024
Copy link
Contributor

@alexdewar alexdewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes that you've made all look correct, BUT we want a v2 of the kevinhall.json schema, not a modified v1. If we just change v1, then all the existing config files out there (including the ones in the examples repo) will start failing validation, even though they're well formed files (for old versions of HGPS, anyway).

You need to do what I did with the staticlinear.json schema and copy it over to the v2 folder, then update any $ref properties to point to the right subschemas (in the v1 folder) before making changes.

You'll also need a v2 of dynamic.json (see what I did for static.json for an example).

@jamesturner246
Copy link
Contributor Author

Ah I see. Done 👍

Copy link
Contributor

@alexdewar alexdewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jamesturner246 jamesturner246 merged commit f52b01e into main Oct 4, 2024
7 checks passed
@jamesturner246 jamesturner246 deleted the sync_schemas branch October 4, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] schemas for KH and staticlinear params need syncing
2 participants