Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement stats calculations for new
calculated_stats_
container #468Implement stats calculations for new
calculated_stats_
container #468Changes from 2 commits
d00133e
ed573ed
3b259be
891b71d
155757c
f915dcc
88ca8ce
acf8067
52e23d9
e4656e2
dfc7e12
fa85412
34d625a
a7d8000
85f23a9
9070c85
97a8ca5
2ce17d8
ed0bcba
e8066f1
2f55b9f
09bbeb5
c99d6cf
b5c1fd5
ddc5198
e74050d
49227a9
6c592d3
ff7fa5a
4997ac4
667200c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might not be completely understanding what these data structures do... But am I right in thinking
channel_index_
contains indexes intochannels_
? If so, could you just makechannels_
astd::map<std::string, std::string>
(I'm guessing it needs to be ordered...) and dropchannels_index_
?