Allow HTTP redirects for file downloads #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PS -- I noticed download_file() was pointlessly returning an input argument, so I removed it. |
It turns out GitHub often redirects file downloads to another URL, which the current code won't handle. Fix by setting telling libcurl to allow this (it's disabled by default). Fixes #457.
hgps::data::download_file() takes a download path and also returns that same path, which is pointless. Change return type to void.
alexdewar
force-pushed
the
allow_http_redirects
branch
from
d47a81b to
22a63e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out GitHub often redirects file downloads to another URL, which the current code won't handle. Fix by telling libcurl to allow this (it's disabled by default).
Fixes #457.
With this fix, we can finally use data from the
healthgps-datarepo as an input source directly 😄See: https://github.com/imperialCHEPI/healthgps-data/releases/tag/20240624