Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Don't run clang-tidy checks for dependabot PRs #417

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

alexdewar
Copy link
Contributor

@alexdewar alexdewar commented Jun 4, 2024

Ok, here's my less horribly insecure attempt at fixing this. If we just don't run the clang-tidy checks for PRs from bots, that should fix things.

While I was at it, I borrowed Adrian's workflow for auto-merging bot PRs, because I thought that would be useful.

Fixes #409. Closes #410.

Copy link
Contributor

github-actions bot commented Jun 4, 2024

clang-tidy review says "All clean, LGTM! 👍"

@alexdewar alexdewar force-pushed the fix_dependabot_perms_securely branch from e2c70ed to 85456b2 Compare June 4, 2024 15:19
Copy link
Contributor

github-actions bot commented Jun 4, 2024

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
Copy link
Contributor

github-actions bot commented Jun 4, 2024

clang-tidy review says "All clean, LGTM! 👍"

@alexdewar alexdewar marked this pull request as ready for review June 5, 2024 07:52
Copy link
Contributor

@jamesturner246 jamesturner246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@alexdewar alexdewar force-pushed the fix_dependabot_perms_securely branch from 85456b2 to 3dafd86 Compare June 6, 2024 10:06
@alexdewar alexdewar enabled auto-merge June 6, 2024 10:06
Copy link
Contributor

github-actions bot commented Jun 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

@alexdewar alexdewar merged commit 399afa4 into main Jun 6, 2024
5 checks passed
@alexdewar alexdewar deleted the fix_dependabot_perms_securely branch June 17, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-merge PRs from bots [BUG] Dependabot PRs all failing CI checks
2 participants