Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous PR purescript#33, the outdated dependency pump 1 has been replace by native streams pipeline 2, which intended to be drop-in replacement given ported by its original author (nodejs/node#19828).
It seems to flaky for some Docker related setups (i.e. computing resources intensive), since it has a lot of moving parts (node & npm versions) involved, I'd like to patch with this minimal changes by having 1 second delay before the untar pipe proceed to its next tasks.
To preview & verify, for Node.js version >= v16 (shipped with npm v8) could use the
overrides
syntax to select this patch by modify thepackage.json
:For Node.js v14 consider adding an extra step in
Dockerfile
to upgrade builtin npm to v8 firstresolves purescript#37
/cc @mrskug @sjpeterson @rhendric
Footnotes
https://github.com/mafintosh/pump ↩
https://nodejs.org/docs/latest-v14.x/api/stream.html#stream_stream_pipeline_streams_callback ↩