Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--- #1

Closed
wants to merge 1 commit into from
Closed

--- #1

wants to merge 1 commit into from

Conversation

imcotton
Copy link
Owner

In previous PR purescript#33, the outdated dependency pump 1 has been replace by native streams pipeline 2, which intended to be drop-in replacement given ported by its original author (nodejs/node#19828).

It seems to flaky for some Docker related setups (i.e. computing resources intensive), since it has a lot of moving parts (node & npm versions) involved, I'd like to patch with this minimal changes by having 1 second delay before the untar pipe proceed to its next tasks.

To preview & verify, for Node.js version >= v16 (shipped with npm v8) could use the overrides syntax to select this patch by modify the package.json:

  },
+ "overrides": {
+   "purescript-installer": "github:imcotton/npm-installer#untar-pipe-racing-delay"
+ },
  "devDependencies": {
    "purescript": "~0.15.7"
  },

For Node.js v14 consider adding an extra step in Dockerfile to upgrade builtin npm to v8 first

FROM node:14
RUN npm install -g npm@8

resolves purescript#37

/cc @mrskug @sjpeterson @rhendric

Footnotes

  1. https://github.com/mafintosh/pump

  2. https://nodejs.org/docs/latest-v14.x/api/stream.html#stream_stream_pipeline_streams_callback

@imcotton
Copy link
Owner Author

imcotton commented Nov 28, 2022

oops, wrong repo, recreate at purescript#38

@imcotton imcotton closed this Nov 28, 2022
@imcotton imcotton changed the title Set 1s delay for untar pipes to avoid spawn racing --- Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installer fails in docker
1 participant