Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jwhitehorn master #5

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Jwhitehorn master #5

wants to merge 14 commits into from

Conversation

zeos90
Copy link

@zeos90 zeos90 commented Mar 1, 2017

Pull in latest changes from Jwhitehorn. Most seem to be gemspec stuff but figured we should keep up to date.

@zeos90 zeos90 requested review from pavel-so and bpohoriletz March 1, 2017 17:40
@radiohead
Copy link

@zeos90

Won't it be easier to simply cherry-pick the following commits:

The rest looks like renaming the gem and changing version - not sure it's needed.

@zeos90
Copy link
Author

zeos90 commented Mar 3, 2017

@radiohead That would get the important changes but I think the lack of a merge would make it more difficult to pull in the changes from the upstream again later. Granted given the last commit was from 2014 that may not really come up. If we aren't worried about tracking jwhithorens a cherry pick sounds cleaner.

@radiohead
Copy link

@zeos90 I vote for cherry-picking, but I'm not picky on that (pun intended) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants