New model for root viewmodels #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisandreae
force-pushed
the
root-viewmodels
branch
2 times, most recently
from
8c083c2 to
362d98e
Compare
| case fupdate | ||
| when FunctionalUpdate::Append | ||
| # If we're referring to existing members, ensure that they're removed before we append/insert | ||
| existing_refs = fupdate.contents |
There was a problem hiding this comment.
I prefer the old name. I thought existing_refs was like child_datas, ie, the before state. The variable holds exactly the refs that are being moved by the current append action.
chrisandreae
force-pushed
the
root-viewmodels
branch
from
17019e5 to
5460280
Compare
Punt on doing this for now, because it'll affect a lot of the tests, but I think that we're going to want to do this. #126 |
thefloweringash
approved these changes
Jul 4, 2019
chrisandreae
added a commit
that referenced
this pull request
Jul 8, 2019
chrisandreae
added a commit
that referenced
this pull request
Jul 8, 2019
chrisandreae
added a commit
that referenced
this pull request
Jul 8, 2019
Removes support for explicit shared on associations. ViewModels are now explicitly declared as either roots or nested children. Removes support for `optional` associations and dynamic prune/include in seralization. Associations may now be `external`. External associations are never (de)serialized as part of the parent, and may only be manipulated externally with `AssociationManipulation`. Fixes #100
chrisandreae
force-pushed
the
root-viewmodels
branch
from
93837cd to
83df58a
Compare
chrisandreae
added a commit
that referenced
this pull request
Jul 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100
sharedwith marking viewmodels asrootor notexternalassociations, which can only be viewed/manipulated via AssociationManipulation. External associations may only be to root viewmodels.