Merge pull request #205 from iknow/batch-delete

Support atomic batch deletion

lib/iknow_view_models/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module IknowViewModels
-  VERSION = '3.10.1'
+  VERSION = '3.11.0'
 end

lib/view_model/active_record/controller.rb

@@ -56,9 +56,14 @@ def create(serialize_context: new_serialize_context, deserialize_context: new_de
   end
 
   def destroy(serialize_context: new_serialize_context, deserialize_context: new_deserialize_context)
+    viewmodel_ids = parse_param(
+      :id, with: IknowParams::Serializer::ArrayOf.new(ViewmodelIdSerializer, allow_singleton: true))
+
     viewmodel_class.transaction do
-      view = viewmodel_class.find(viewmodel_id, eager_include: false)
-      view.destroy!(deserialize_context: deserialize_context)
+      views = viewmodel_class.find(viewmodel_ids, eager_include: false)
+      views.each do |view|
+        view.destroy!(deserialize_context: deserialize_context)
+      end
     end
     render_viewmodel(nil)
   end
@@ -91,8 +96,28 @@ def prerender_viewmodel(...)
 
   private
 
+  # Viewmodel ids are permitted to be either integers or strings
+  class ViewmodelIdSerializer < IknowParams::Serializer
+    def initialize
+      super(::Object)
+    end
+
+    def load(val)
+      case val
+      when ::Integer, ::String
+        val
+      else
+        raise IknowParams::Serializer::LoadError.new(
+                "Incorrect type for #{self.class.name}: #{val.inspect}:#{val.class.name}")
+      end
+    end
+
+    set_singleton!
+    json_value!
+  end
+
   def viewmodel_id
-    parse_param(:id)
+    parse_param(:id, with: ViewmodelIdSerializer)
   end
 
   def migrated_deep_schema_version

lib/view_model/active_record/controller_base.rb

@@ -156,11 +156,13 @@ def arvm_resources(resource_name, options = {}, &block)
                   name_route = { as: '' } # Only one route may take the name
                   post('', action: :create, **name_route.extract!(:as)) unless except.include?(:create) || !add_shallow_routes
                   get('',  action: :index,  **name_route.extract!(:as)) unless except.include?(:index)  || !add_shallow_routes
+                  delete('', action: :destroy, as: :bulk_delete) unless except.include?(:destroy) || !add_shallow_routes
                 end
               end
             else
               collection do
                 get('', action: :index, as: '') unless except.include?(:index)
+                delete('', action: :destroy, as: :bulk_delete) unless except.include?(:destroy)
               end
             end
           end

test/unit/view_model/active_record/controller_test.rb

@@ -167,6 +167,22 @@ def test_update
   end
 
   def test_destroy
+    other_parent = make_parent
+    parentcontroller = ParentController.new(params: { id: [@parent.id, other_parent.id] })
+    parentcontroller.invoke(:destroy)
+
+    assert_equal(200, parentcontroller.status)
+
+    assert(Parent.where(id: @parent.id).blank?, "record doesn't exist after delete")
+    assert(Parent.where(id: other_parent.id).blank?, "record doesn't exist after delete")
+
+    assert_equal({ 'data' => nil },
+                 parentcontroller.hash_response)
+
+    assert_all_hooks_nested_inside_parent_hook(parentcontroller.hook_trace)
+  end
+
+  def test_batch_destroy
     parentcontroller = ParentController.new(params: { id: @parent.id })
     parentcontroller.invoke(:destroy)