Passwordless-GDM integration: smartcard and passkey #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It returns NULL on error, but this wasn't checked. Fixes: ceeffa9 ("Responder: generate JSON message for GUI") Signed-off-by: Iker Pedrosa <[email protected]>
Integration with GDM requests two prompts for smartcard so modifying the prompt_config structure. In addition, implement all the functions needed to manipulate the structure for these new prompts. Finally, add unit-tests for the new functions. Signed-off-by: Iker Pedrosa <[email protected]>
These new options are needed by the GDM integration, but they can be
reused for CLI prompting.
:config: New options to tune smartcard prompting: 'init_prompt' and
'pin_prompt'.
Signed-off-by: Iker Pedrosa <[email protected]>
This API gets all the elements with the selected response type data from the response_data linked list. Includes unit tests. Signed-off-by: Iker Pedrosa <[email protected]>
ikerexxe
force-pushed
the
gdm_passkey_sc
branch
3 times, most recently
from
4dc0e56 to
a808f15
Compare
Implement a set of functions to retrieve the smartcard data and generate the JSON message with it. Implement new unit test and adapt the existing ones to take into account the new data. Signed-off-by: Iker Pedrosa <[email protected]>
TODO: delete Signed-off-by: Iker Pedrosa <[email protected]>
Parse GUI reply for smartcard and set the appropriate data in `sss_auth_token` structure. Signed-off-by: Iker Pedrosa <[email protected]>
This new option is needed by the GDM integration, but it can be reused for CLI prompting. :config: New option to tune passkey prompting: 'pin_prompt'. Signed-off-by: Iker Pedrosa <[email protected]>
Several of the functions in `pamsrv_json` had lots of arguments and I'm about to add more for the passkey authentication mechanism. Reduce these arguments by creating a structure that will contain all these data. Signed-off-by: Iker Pedrosa <[email protected]>
Implement a set of functions to retrieve the passkey data and generate the JSON message with it. Implement new unit test and adapt the existing ones to take into account the new data. Signed-off-by: Iker Pedrosa <[email protected]>
`sss_authtok_set_passkey_pin` provides a way to set the passkey PIN in the authtok structure for both local and kerberos passkey authentication. Signed-off-by: Iker Pedrosa <[email protected]>
Parse GUI reply for passkey and set the appropriate data in `sss_auth_token` structure. Signed-off-by: Iker Pedrosa <[email protected]>
Due to the difficulty of having a single source for the prompts strings for both CLI and GUI, it has been decided to leave them fixed and use the strings proposed by Allan in the mockups design. Signed-off-by: Iker Pedrosa <[email protected]>
ikerexxe
force-pushed
the
gdm_passkey_sc
branch
from
a808f15 to
95b3270
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.