Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.md #90

Merged
merged 7 commits into from
Sep 12, 2024
Merged

Conversation

Prokopchuk-Valentin
Copy link
Contributor

Дополнил в описании пару фраз и небольшой пример использования на react

Дополнил в описании пару фраз и небольшой пример использования на react
apps/website/docs/factories/index.md Outdated Show resolved Hide resolved
apps/website/docs/factories/index.md Outdated Show resolved Hide resolved
apps/website/docs/factories/index.md Outdated Show resolved Hide resolved
@Prokopchuk-Valentin
Copy link
Contributor Author

@igorkamyshev, сможешь принять?

Copy link
Owner

@igorkamyshev igorkamyshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Круто, спасибо!

Оставил пару минорных комментов 🙏

apps/website/docs/factories/index.md Outdated Show resolved Hide resolved
apps/website/docs/factories/index.md Outdated Show resolved Hide resolved
Copy link
Owner

@igorkamyshev igorkamyshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Примеры получились какие-то немножко не качественные. Если нет экспертизы написать для свелта корректный пример, давай его просто удалим и оставим реакт и вью 🙏

::: details Example usage in Svelte
```svelte
<script>
import { useUnit } from 'effector-svelte';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Но ведь пакета effector-svelte не существует?..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

удалил, да, по svelte ошибся

@igorkamyshev igorkamyshev merged commit 66c216c into igorkamyshev:master Sep 12, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants